Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: move TSC voting member(s) to regular member(s) #47180

Merged
merged 1 commit into from
Mar 23, 2023
Merged

meta: move TSC voting member(s) to regular member(s) #47180

merged 1 commit into from
Mar 23, 2023

Conversation

nodejs-github-bot
Copy link
Collaborator

This PR was generated by tools/find-inactive-tsc.yml.

@nodejs/tsc @ChALkeR

ChALkeR did not participate in three consecutive TSC votes: 2022-09-15-0.json 2022-11-30-0.json 2022-11-30-1.json

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. doc Issues and PRs related to the documentations. labels Mar 21, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 23, 2023
@nodejs-github-bot nodejs-github-bot merged commit a2c3061 into main Mar 23, 2023
@nodejs-github-bot nodejs-github-bot deleted the actions/inactive-tsc branch March 23, 2023 00:49
@nodejs-github-bot
Copy link
Collaborator Author

Landed in a2c3061

ChALkeR
ChALkeR reviewed Mar 23, 2023
View reviewed changes
Copy link
Member

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented Mar 24, 2023

I've performed the offboarding steps in https://github.com/nodejs/TSC/blob/fe4278b5208e3c10667f541a037df50b9cfca03a/ONBOARDING.md#offboarding

@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@nodejs-github-bot @RafaelGSS
meta: move TSC voting member(s) to regular member(s)
ac85146 
PR-URL: #47180
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@nodejs-github-bot @RafaelGSS
meta: move TSC voting member(s) to regular member(s)
5419535 
PR-URL: #47180
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@nodejs-github-bot @danielleadams
meta: move TSC voting member(s) to regular member(s)
da16ca7 
PR-URL: #47180
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChALkeR ChALkeR ChALkeR left review comments

@RaisinTen RaisinTen RaisinTen approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@aduh95 aduh95 aduh95 approved these changes

@legendecas legendecas legendecas approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nodejs-github-bot @Trott @ChALkeR @lpinca @joyeecheung @legendecas @aduh95 @RafaelGSS @RaisinTen